search

emavgl / oinkoin

Oinkoin is a flutter app for helping you managing your expenses. No internet required.
GNU General Public License v3.0
165 stars 11 forks source link

add translation to [Português (Brasil)] #57

Closed cubiquitous closed 10 months ago

cubiquitous commented 10 months ago

hi, I know that there's a crowdin link to add translation but i'm not sure how to add one for Português (Brasil). I would appreciate if you guide me or, if you are the one that has to create, you would open.

thx in advance

emavgl commented 10 months ago

Hi, thanks for being interested in contributing with the translations.

I have just enabled Portuguese and Portuguese (Brazil) in Crowdin. You should be able to see them in the dashboard and continue with the translations.

Thank you

cubiquitous commented 10 months ago

should I keep the escaped codes? ex: image

emavgl commented 10 months ago

Yes please, keep them :) it is just some break-line, otherwise it will be too long.

emavgl commented 10 months ago

Sorry, just to clarify. It is not an escaping character but you should keep the \n which is a special character indicating the break-line.

emavgl commented 10 months ago

@cubiquitous, when you finish, let me know, I'll merge your changes and do a release with those :)

cubiquitous commented 10 months ago

@emavgl currently I'm having a debate with many friends that is in a draw so I'll ask you instead:

in Pt-BR there's two possible valid translations to the word "record":

Registro is more formal than normal and Item sounds more natural and (arguably) accessible to regular people. I honestly prefer Item, but really depends if you want something more formal or not.

emavgl commented 10 months ago

Item is ok 👌😊 your call

cubiquitous commented 10 months ago

then is all done.

one a sidenote, some of the context are really lacking. for instance on:

Key: Save
Context: -> Save

Save can translate to "salvar" (as in store data) or "economizar" (to save money).

I'm not sure how the context could be improved there, but it could be confusing for some. maybe put directions where one can see the original version.

emavgl commented 10 months ago

That's totally right. There is room for improvement. I'll try adding the context.

In your case, it is meant as Store Data.

Did you make both Portuguese and Portuguese Brazil or just this last?

cubiquitous commented 10 months ago

I did only for Portuguese Brazil (PT-BR). but if you want I can ask my brother to translate to Portuguese (PT-PT) since he lives in Portugal and can ask people about the differences (which should be very minimal).

emavgl commented 10 months ago

No pressure - just if he has time 😉

Can I merge your changes at the moment? So you can see your translations already.

cubiquitous commented 10 months ago

No pressure - just if he has time 😉

i'll ask him

Can I merge your changes at the moment?

yes. that would be great

emavgl commented 10 months ago

Sorry, apparently I got a problem with the mapping pt_BR. I'll take some more time to test it properly, I'll probably do it tomorrow.

Thank you again for your contribution!

cubiquitous commented 10 months ago

If I made any mistake let me know and I will correct. It's my first time doing this so I probably did something wrong somewhere.

emavgl commented 10 months ago

No problem, in this case the problem is on my side, when importing the translation.

In any case there is surely the possibility for any fix. You can constantly update the translations and they will be live on the next release.

cubiquitous commented 10 months ago

I checked all my translations, improved a few and found one that had an extra escape code (which I don't know where it came from). it may have been that

emavgl commented 10 months ago

Hi

I have merged the new translations and fix the problem on my side. You should find Portoguese already available in https://github.com/emavgl/oinkoin/releases/tag/1.0.37 - soon an update will appear for Google Play, and later on F-Droid. Let me know when you have a chance to try this out.

I have added for now also Portoguese PT other than BR. At the moment, it has the same translations. Better than not having it at all, I think.

Then, I'll close this issue. But you can continue to add or modify the translations whenever you want. I'll then add the change in the next releases.

Thanks again!

cubiquitous commented 10 months ago

so, I checked and sent to a few friends and there are feedback related to translation and another one about something else. for now i'll focus on the translation, but if you wish i'll tell the other.

edit: I also added 2 translations that somehow didn't saved, but fortunately the meaning of the original is the same as the translation

emavgl commented 10 months ago

Ehi, it should be fixed now, you will have it in the next release.

There was a string missing:

which I have tried to translate myself in Portoguese, you may want to have a look maybe.

emavgl commented 10 months ago

fyi: Just released 1.0.39

cubiquitous commented 10 months ago

Ehi, it should be fixed now, you will have it in the next release.

There was a string missing:

  • Edit record

which I have tried to translate myself in Portoguese, you may want to have a look maybe.

I thought I had answered, but it's a perfect translation.

Regarding the pt-pt my brother start doing, but it'll probs take a few days due to timezones.

emavgl commented 10 months ago

No problem, thanks for the confirmation. :) I'll close this PR then. Thanks again for contributing. I'll see automatically the changes to the Portuguese version via Crowdin.