feat(record-creation): add typeahead for record name

emavgl / oinkoin

Oinkoin is a flutter app for helping you managing your expenses. No internet required.

GNU General Public License v3.0

164 stars 11 forks source link

feat(record-creation): add typeahead for record name #90

Closed qvalentin closed 9 months ago

qvalentin commented 9 months ago

Hi, thanks for the nice app.

This feature should make it easier to keep an organized collection of records by always using the same name via the suggestions. It's my first time using flutter, so tell me if I made some mistakes.

Also my formatter changed to whole file, so the diff might be difficult to read, what formatter should I use to avoid this?

emavgl commented 9 months ago

Hi! Thank you so much for the PR. It seems a nice idea. These have been some packed days for me, I will have a look as soon as possible.

qvalentin commented 9 months ago

This should be mostly ready now, the formatting still as me wondering what we should do about it.

emavgl commented 9 months ago

Hi @qvalentin,

I just merged a new PR that rework all the customization page. It was quite a huge one. Also, I have formatted all the files using dart format lib.

I have added a https://git-scm.com/docs/githooks#_pre_commit to run the formatting before every commit.

Could you please apply the same formatting and solve the conflicts (I think they are due just to the formatting, I don't think I have changed those files).

Thank you!

emavgl commented 9 months ago

Hi there, I have tried again on my phone and it looks just great and I am ready to merge. However, I wanted to discuss with you about some changes I'll do after the merge:

When you click on the textbox, it opens the suggestions automatically. While it can be useful prompting the user all the choices when he has no idea, I think it can be a bit overwhelming for the user who maybe would like just to start writing on it. Also, at the moment, the empty string is part of the choices and I think it shouldn't.

To address that, I'd prefer to prompt the list of suggestions just when the user starts pressing some keys. Also, I'll add an option in the customisation page to hide the suggestions and have the current behaviour.

I hope it is ok, thank you so much for your contribution :)

qvalentin commented 9 months ago

Sounds good, thank you :)