search

emb4 / Sprinkle-of-Yeezus

A silly app that sends kanye quotes to your phone
1 stars 1 forks source link

Refactor of Settings.swift #1

Open AndrewBoryk opened 6 years ago

AndrewBoryk commented 6 years ago

https://github.com/emb4/Sprinkle-of-Yeezus/blob/e32368e045dbfde902ead7c29f0ccfba4303ee3e/Sprinkle%20of%20Yeezus/Settings.swift#L13-L62

Hey Eric! I looked over the file you asked me to, and I'm available to walk you through ways you can go about accomplishing this task.

I figured that first we could go over the structure of your code, so that way we could build a consistency across the project so that if other people submit code then they will do so in the format you desire.

Let me know what you'd like to do!

emb4 commented 6 years ago

Sure, anything helps. I know I'm kinda going through and messing with things so it definitely doesn't have a structure right now lol

AndrewBoryk commented 6 years ago

Hey Eric! Alright, so I opened up a PR on your branch. Rather than building out any functionality (other than just adding a couple lines to finish off your notification stuff), I made structural and syntactical changes.

I left a ton of comments on my code, explaining what was going through my head when I wrote each line. If anything needs to be clarified more, ask as many questions as you want. I hope you find it all really helpful!