embark-theme / vim

An ambitious theme for vim
https://embark-theme.github.io/
MIT License
650 stars 26 forks source link

Colorscheme looks weird in Go #1

Closed msal4 closed 4 years ago

msal4 commented 4 years ago

After enabling embark, this is how it looks in a Go file.

Screen Shot 2020-07-10 at 1 11 29 AM

Is this how it's supposed to look?

skbolton commented 4 years ago

Looks like you don't have truecolor turned on. Did you set termguicolor in your vimrc?

msal4 commented 4 years ago

Yes, it looks the same.

skbolton commented 4 years ago

what terminal are you using?

msal4 commented 4 years ago

iTerm

msal4 commented 4 years ago

iTerm

skbolton commented 4 years ago

Does the syntax look weird in all filetypes? Like markdown and whatnot?

skbolton commented 4 years ago

Also has your vimrc changed from whats here? You don't have termguicolors enabled in that rc

msal4 commented 4 years ago

After setting termguicolors it looks different but the comments are highlighted. are they supposed to look like this?

Screen Shot 2020-07-10 at 9 33 45 PM

yes it looks the same on other types of files

Screen Shot 2020-07-10 at 9 34 59 PM
skbolton commented 4 years ago

Those are italics. You can either follow the guide here to get italics and true color working. Or disable italics in the theme by setting let g:embark_terminal_italics = 0. These are details I an working on documenting better for this repo.

msal4 commented 4 years ago

thanks, it's looking good now:)