search

embark-theme / vim

An ambitious theme for vim
https://embark-theme.github.io/
MIT License
659 stars 26 forks source link

add new airline theme #18

Closed unknowledgeable closed 2 years ago

unknowledgeable commented 4 years ago

Ok I think I've done what you suggested and made a airline-rewrite branch to push to. Wasn't sure where to make the PR as I saw you have a "airline-sync-fix" branch but GitHub said it was unable to merge there so I went for master. Is that right?

As for the rewrite, I didn't actually use the "dark" template theme because it wasn't actually a template, it was more of a demo of the features and helper functions you can use in airline themes.

Some other themes I found had what I think is a bit of an over-engineered and convoluted way of defining the colours. They defined them in colour arrays, then had to make new "section arrays" where each element is calling one element from a colour array and then another level of mode arrays calling those sections (array-ception). That combined with using helper functions and whatever else it ends up being pretty hard to decipher, not very flexible and even though designed to be less error prone, was likely moreso.

IMO it wasn't as pretty but far easier and more effective to just hard-code the values (with the help of colorizer to see what I was doing) and not have to rely on any helper functions etc.

Not had any issues with sync using this rewrite for a couple of days but did notice it was a bit buggy with one of the other themes that relied on the helper functions so I suspect there's a problem there somewhere.

What do you think?

ALL3

skbolton commented 4 years ago

I have done a lot of clean up work recently on master but I avoided doing anything in the airline theme to help you not have to deal with conflicts. Once this PR is merged I would like to get the cleanup applied to the airline theme. Either of us can do it. If you feel up to more contributions then I can fill you in on the work. It's very simple. If not I appreciate what you've done and I can take it from here.

unknowledgeable commented 4 years ago

Just want to say I'm not ignoring this, my laptop's had known fault hardware issue so I've had to send it away to get fixed (ETA 10 days). In the meantime the only other machine I have is pretty old and I've made the mistake of going down the arch linux rabbit hole to get it snappy. The install is not going well so far...

skbolton commented 4 years ago

If you need arch help let me know

skbolton commented 3 years ago

@unknowledgeable there has been some tweaks to the color palette since you created this PR. I have been thinking about picking up this work and getting it across the line. Are you still working on this?

skbolton commented 2 years ago

Closing as stale