embark-theme / vim

An ambitious theme for vim
https://embark-theme.github.io/
MIT License
657 stars 26 forks source link

V2 theme cleanup #23

Closed skbolton closed 4 years ago

skbolton commented 4 years ago

This commit is a large overhaul of things that have always bothered me about the theme. Overall this update gives the theme more unity and the right level of contrast that I have always wanted.

This color works wonderful for pop up messages and has become the new Pmenu color. The gap between the dark purples and lighter grays was very large and this color becomes a subtle color to put in the middle of them.

This was the old linenr and visual highlight color. It never worked well as the linenr because it had poor contrast, but it was a much better visual highlight color than #585273. There is no reason to not have both in the project at the same time.

The old white color of #A6B3CC was not being used in a core way of the theme. One of my biggest gripes was that the color of comments was very gray without having unity with the theme. There was an opportunity to make this color work better for comments and give it its due in the project.

The color codes before had unique names which made it frustrating to reference them. I don't want to get rid of the spirit that having these names bring to the theme thrown away though. Instead each "group" of colors will have its own name and number designation. This is very similar to Nord themes take (a huge influence of this theme).