fix(nvim-lsp): updated highlight group names

embark-theme / vim

An ambitious theme for vim

https://embark-theme.github.io/

MIT License

648 stars 26 forks source link

fix(nvim-lsp): updated highlight group names #29

Closed pyrho closed 3 years ago

pyrho commented 3 years ago

👋

diagnostic-nvim got more or less merged with neovim master; and with that the highlight group names have been changed for consistency with the rest of the LSP related stuff.

I chose to leave the previous groups in there so that it won't mess up the install for people not running bleeding edge neovim:master.

See https://github.com/nvim-lua/diagnostic-nvim/issues/73 for more info.

skbolton commented 3 years ago

Thanks for staying on top of this. I am guessing when neovim hits version 5 as an official release we can delete the old legacy rules?

pyrho commented 3 years ago

I am guessing when neovim hits version 5 as an official release we can delete the old legacy rules?

Indeed, but there is a high chance that I'll forget to do that when nvim 5 will be out (:

skbolton commented 3 years ago

I'll watch it as well and make the change when time comes. Thanks again.