search

embark-theme / vim

An ambitious theme for vim
https://embark-theme.github.io/
MIT License
659 stars 26 forks source link

line number contrast isn't fantastic #4

Closed imajes closed 4 years ago

imajes commented 4 years ago

Is there any chance to make an option to boost the contrast of the line numbers? :)

thanks, love the scheme. :)

skbolton commented 4 years ago

Yeah this is one that I figured would come up. I think a configuration to boost the value by a percentage would be a good option.

skbolton commented 4 years ago

So I am leaning towards offering three variants on this. Let me know what you think about these colors. The soft variant would be what it is today. The default variant would be #585273 and the hard variant would be #716B8C.

To try any of these out you can call hi LineNr guifg=#585273 anywhere after you have set the embark colorscheme, and of course you would just change that color code to whatever you want to test out.

skbolton commented 4 years ago

Here are quick previews of the above codes though

Soft (current)

soft

Default (10% brighter)

default

hard (20% brighter)

hard
imajes commented 4 years ago

I like default. what's doing your active line-highlighting?

skbolton commented 4 years ago

I have created the branch linenr-contrast which changes the linenr to be that default color if you want to point your packager to that branch.

As far as the cursorline that is configured in the theme you just have to turn it on in vim set cursorline

skbolton commented 4 years ago

In the end I have decided that I don't want to have too much configuration in this project. Also since users can always override I would rather go with defaults that work for me and for others. This is resolved in #11 by changing the Eclipse color to #585273

imajes commented 4 years ago

@skbolton sounds more than reasonable to me. i'm always a fan of documenting it, to help others in the future, but gh search is pretty decent now, so that's not a major issue.

skbolton commented 4 years ago

@imajes I am working on a system to produce a change log so that users can undo things where they feel that the theme drifted in their expectations. Would you feel that would help?