embark-theme / vim

An ambitious theme for vim
https://embark-theme.github.io/
MIT License
650 stars 26 forks source link

Airline theme colors go out of sync after using CoC in neovim #5

Closed unknowledgeable closed 2 years ago

unknowledgeable commented 4 years ago

I'm getting some strange behaviour with this airline theme where it doesn't seem to refresh the colours correctly after inserting an emmet abbreviation using CoC. I'm using the example vim config found here

Expected:

Screenshot 2020-08-05 at 13 51 49

Current behaviour:

Screenshot 2020-08-05 at 13 51 40

It seems to go back in sync to the expected behaviour if I take focus away from my terminal window and click on it again or use :AirlineRefresh I'm not getting this problem using any other vim-airline Theme (I'm definitely using a powerline patched font, etc)

I've tried setting the theme manually with let g:airline_theme='embark' but the problem persists

Steps to reproduce with Coc, emmet-vim and coc-emmet installed:

nvim index.html
i ! <TAB> <CR>

Any thoughts?

vim version: NVIM v0.4.3 coc.nvim version: 0.0.78-0ff42027ff term: iTerm.app platform: darwin all plugins up to date according to Plug

PS: Loving the theme btw! Thanks for putting out there!

skbolton commented 4 years ago

That is very weird behavior. I will have to look into this and do my best to fix. I am not an airline user though so I might have to request that you help me come to a resolution on this.

unknowledgeable commented 4 years ago

@skbolton strange indeed, is there a theme you based yours on that I could test to see if I get the same behaviour?

skbolton commented 4 years ago

@unknowledgeable I basically pulled the challenger deep theme airline theme into the code base and adjusted the palette to match embark

unknowledgeable commented 4 years ago

@skbolton I tested the challanger deep theme and it seems to work fine, odd. Had a quick scan through a diff of embark and challenger_deep but couldn't find anything obvious, but was pretty hard to see any out of place punctuation in the diff!

Might be worthwhile going through the process of replacing colours in airline's default "dark" theme instead, just for the sake of completeness and compatibility?

skbolton commented 4 years ago

Yeah I think that's a good idea. Also I wouldn't mind keeping all the comments and everything in that example. I think it will help me and anyone else out later down the road to make fixes and contributions.

unknowledgeable commented 4 years ago

Update on this, I had a mess around with the default theme by replacing the colours with the closest matches from embark.vim and the result wasn't great:

Screenshot 2020-08-11 at 16 25 02

I much prefer the original embark one, when it works!

I'm not sure how you want to proceed with it but there are quite a few aesthetic decisions for you to make to get it looking good.

skbolton commented 4 years ago

No sync issues when you did that though?

unknowledgeable commented 4 years ago

Nope all working fine as far as I can tell!

skbolton commented 4 years ago

Okay I will try and make time in the next few weeks to use the template like you did above but get the colors to align with what I have in the current theme.

unknowledgeable commented 3 years ago

So in my rewrite I've got it looking like this so far and thankfully it's no longer bugging out:

ALL3

What I've done:

Any thoughts or opinions?

skbolton commented 2 years ago

Closing as stale. Reopen if issue persists.