search

embark-theme / vim

An ambitious theme for vim
https://embark-theme.github.io/
MIT License
648 stars 26 forks source link

fix typo: change 'underdash' to 'underline' #54

Closed PerpetualCreativity closed 1 year ago

PerpetualCreativity commented 1 year ago

Fixes issue #53.

skbolton commented 1 year ago

Interesting I wonder how this option isn't cross compatible. Maybe it's nvim only? Anyways thanks for the fix!

PerpetualCreativity commented 1 year ago

@skbolton I'm running the nightly version of neovim and getting the 'Illegal value: underdash' error. Are you running a GUI version of neovim? I know that (some of?) those support the gui undercurl option.

skbolton commented 1 year ago

No just neovim in kitty terminal. The help docs :help hi have this

    Note that "bold" can be used here and by using a bold font.  They
    have the same effect.
    "undercurl", "underdouble", "underdotted", and "underdashed" fall back
    to "underline" in a terminal that does not support them. The color is

So I thought it was safe. But either way I have merged your change. The issue no longer persists right?

skbolton commented 1 year ago

Oh it is underdashed not underdash.... Strange that I never saw an error pop up.

PerpetualCreativity commented 1 year ago

I don't have the issue anymore, but it might make sense to go back to underdashed :)

skbolton commented 1 year ago

I am okay with it how we have it. I was getting a little overly fancy