embark-theme / vim

An ambitious theme for vim
https://embark-theme.github.io/
MIT License
657 stars 26 forks source link

Add support for config italics and bold. #70

Closed brunoferromega closed 2 months ago

brunoferromega commented 3 months ago

Could you add support for edit some text/syntax styles into embark-theme ? I guess something like that it's a good solution ->

Screenshot from 2024-06-28 21-50-19

e.g. : link for theme above -> https://github.com/mellow-theme/mellow.nvim

skbolton commented 3 months ago

Out of curiosity what things are you trying to toggle bold/italic on or off for?

brunoferromega commented 3 months ago

Well, I would like to functions and boolenas in italic - keywords and macros in italic and bold, because in general I think it looks good when we have syntax details in outstanding.

skbolton commented 3 months ago

I would like to avoid too many configuration options. Especially since it is quite easy to do this sort of customizing with vimscript/lua. After setting the embark theme you can always supply styling overrides. Example using lua.

vim.cmd('colorscheme embark')
vim.cmd('hi @function gui=italic')
vim.cmd('hi @keyword gui=bold')

Have you tried this approach?

brunoferromega commented 2 months ago

Nice, I didn't know that. I'll try, thank you for the attention.

skbolton commented 2 months ago

Sounds good I'll close this for now.