Angular Template for Embark

iurimatias commented 6 years ago

Outline

The goal of this task is to create a ready to use angular template for Embark. This is to be built on top of the typescript template and available here. The template should have:

The necessary packages in package.json for angular
A simple sample code using angular
Additions/Modifications in the webpack to support angular (if required at all...)

This task is meant for the embark version currently in the develop branch, to install:

git clone git@github.com:embark-framework/embark.git
cd embark
npm install
npm link

Afterwards embark version should say 3.2.0-develop

Acceptance Criteria

Running this template with embark run should result in a usable dapp that uses angular as minimal starting point to start using a dapp using angular and embark.
The template has to be based off the one in https://github.com/embark-framework/embark-angular-template
It has to use embark and its pipeline (configured in embark.json (not @angular/cli) and using the embark's webpack config file)

gitcoinbot commented 6 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 100.0 DAI (100.0 USD @ $1.0/DAI) attached to it.

If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
- Want to chip in? Add your own contribution here.
- Questions? Checkout Gitcoin Help or the Gitcoin Slack
- $25,668.72 more funded OSS Work available on the Gitcoin Issue Explorer

gitcoinbot commented 6 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 2 months ago. Please review their action plans below:

1) fabioluxx has been approved to start work.

HI, i work with Angular has been 2 years, can we talk?

Learn more on the Gitcoin Issue Details page.

vs77bb commented 6 years ago

@iamonuwa glad to see you here 🙂WIP PR within a couple days would be appreciated!

iamonuwa commented 6 years ago

Sure, @vs77bb planning on submitting a WIP PR today for review

iamonuwa commented 6 years ago

@gitcoinbot I just submitted a PR #2 hope you won't shout at me today :)

gitcoinbot commented 6 years ago

@iamonuwa Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] warning (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

vs77bb commented 6 years ago

@iamonuwa snoozing Gitcoin Bot, I see @iurimatias left you a comment in the PR 👍

gitcoinbot commented 6 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 100.0 DAI (100.0 USD @ $1.0/DAI) has been submitted by:

@iamonuwa

@StatusSceptre please take a look at the submitted work:

PR by @iamonuwa

Learn more on the Gitcoin Issue Details page
Want to chip in? Add your own contribution here.
Questions? Checkout Gitcoin Help or the Gitcoin Slack
$23,785.01 more funded OSS Work available on the Gitcoin Issue Explorer

gitcoinbot commented 6 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 100.0 DAI (100.0 USD @ $1.0/DAI) has been submitted by:

@StatusSceptre please take a look at the submitted work:

PR by @iamonuwa
PR by @iamonuwa
PR by @iamonuwa

Learn more on the Gitcoin Issue Details page
Want to chip in? Add your own contribution here.
Questions? Checkout Gitcoin Help or the Gitcoin Slack
$22,996.65 more funded OSS Work available on the Gitcoin Issue Explorer

enten commented 6 years ago

UPDATE

I found a way to make embark work with angular-cli.

Check out embark with angular 7 demo here: https://github.com/enten/embark-angular

I encountered an issue related to the placeholder page used during embark build.

The angular-cli uses IndexHtmlWebpackPlugin (a webpack plugin) to add style and script imports dynamically in index.html.

But the current embark pipeline replace placeholder page with the original index.html (which hasn't style and script imports).

I had to patch embark pipeline to avoid this behavior when index.html is not in embark config.

Original post

@iurimatias

It has to use embark and its pipeline (configured in embark.json (not @angular/cli) and using the embark's webpack config file).

Is that means the template won't have a config file angular.json?

I know that can confusing if we have a config file angular.json because some fields are already provided by embark.json.

But in our days, the angular-cli provides features which are required to develop angular applications (scaffolding through schematics and others tasks like extract i18n, linting, launch e2e tests, etc).

Without angular.json (or workspace.json) we can't use the angular-cli.

I'm working and a PR which support angular-cli with a angular.json file.

The webpack.config.js checks the coercion between the angular.json and embark.json:

angular brower builder option outputPath equals embark option buildDir ;
angular browser builder options index, main, polyfills assets, styles and scripts matches with embark option app.

Finally, we build webpack configs (dev and prod) with the angular-devkit/build-angular package.

In that way, we still use embark to build and run the application. And we are able to use the angular-cli for others tasks (scaffolding, etc).

I would like to have your opinion about that kind of implementation (allow angular-cli) for the angular template.

0x-r4bbit commented 6 years ago

Is that means the template won't have a config file angular.json?

@enten that's correct. This issue is about implementing a lightweight template+webpack config for Angular without involving Angular CLI in any way.

I believe there's cool things we could do with Angular CLI in the future. E.g. I know that Angular developer will want to use Angular CLI, not Embark. Maybe there's opportunities to implement schematics for Angular CLI that will add Embark features to it.

But in our days, the angular-cli provides features which are required to develop angular applications (scaffolding through schematics and others tasks like extract i18n, linting, launch e2e tests, etc).

While I agree with the usefulness of all of these features, it doesn't mean that the CLI is required, nor that schematics are. We should still be able to create simple setup that makes stuff work without the Angular CLI. Not saying that it's easy though...

In that way, we still use embark to build and run the application. And we are able to use the angular-cli for others tasks (scaffolding, etc).

This would be a wonderful compromise for now! If we can make this possible as an opt-in, that'd be great. For example, if there's no angular.json stuff should still work (even without using the CLI).

I hope this makes sense. I'd really like to explore what we can do in terms of schematics to extend Angular CLI because again, I know Angular developers prefer Angular CLI over any other CLI tool because it's highly optimized for building Angular apps.

enten commented 6 years ago

This issue is about implementing a lightweight template+webpack config for Angular without involving Angular CLI in any way.

Currently (in the embark-angular experiment) we use the angular devkit (architect, build-angular and core packages) only to generate webpack config dynamically (with the browser builder): we still use embark cli to build/run the project.

I think it's a fast way to generate a webpack config for Angular project and make some adjustements to be compatible with embark.

In my opinion, the real benefits to use Angular come from its devkit. If I can't take advantage of the devkit features, I choose another framework.

Howerver I understand well that the angular template would do better to keep simple and not use angular.json config.

But do you consider it possible to use the devkit to generate the webpack config?

It's easier to generate a webpack config for development or production environment with the devkit.

Maybe there's opportunities to implement schematics for Angular CLI that will add Embark features to it.

I'm totally agreed. It's the better way to make embark and angular compatible (but that will make the embark config app key obsolete).

What is the different purposes of the embark config app key? Is it just used by the embark pipeline to generate webpack config and copy assets?

While I agree with the usefulness of all of these features, it doesn't mean that the CLI is required, nor that schematics are. We should still be able to create simple setup that makes stuff work without the Angular CLI.

Yes I agree too. I can work on a schematics for embark but that will make embark config app key obsolete.

This would be a wonderful compromise for now! If we can make this possible as an opt-in, that'd be great. For example, if there's no angular.json stuff should still work (even without using the CLI).

It's possible to do it easily with Angular Webpack Build Facade.

I hope this makes sense. I'd really like to explore what we can do in terms of schematics to extend Angular CLI because again, I know Angular developers prefer Angular CLI over any other CLI tool because it's highly optimized for building Angular apps.

How about a schematic which extends the browser builder?

vs77bb commented 6 years ago

@iamonuwa Are you still working on this one? Or @enten are you looking to pick this up by clicking 'Start Work' here?

enten commented 6 years ago

@vs77bb

Firstly, we need to find an approach which satisfied acceptance criteria and be agreed by embark team.

I suggested an approach which use angular-cli and require to patch embark pipeline as discussed in embark-framework/embark#989. That approach not satisfy acceptance criteria. We need to find another approach to make embark-angular-template work without angular-cli.

I'm currently working on an approach which works without angular-cli. I will submit the result when last details will be fixed.

Finally, when embark team will agree the approach, we will be able to write the PR and click 'Start Work' here.

StatusSceptre commented 5 years ago

Thanks for the work on this @enten @vs77bb it looks like it tagged the previous worker that wasn't merged and Enten has been approved for this PR he has open. Can you help?

StatusSceptre commented 5 years ago

any update here @PascalPrecht?

gitcoinbot commented 5 years ago

@fabioluxx Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@fabioluxx Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@fabioluxx Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

0x-r4bbit commented 5 years ago

@iurimatias I think with Embark v4 this template effort is kind of obsolete.

Can you confirm?

gitcoinbot commented 5 years ago

@fabioluxx Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@fabioluxx Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@fabioluxx Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@fabioluxx Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This Bounty has been completed.

Learn more on the Gitcoin Issue Details page
Questions? Checkout Gitcoin Help or the Gitcoin Slack
$57,410.40 more funded OSS Work available on the Gitcoin Issue Explorer

gitcoinbot commented 5 years ago

@fabioluxx Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@fabioluxx Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@fabioluxx Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@fabioluxx Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@fabioluxx Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@fabioluxx Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@fabioluxx Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@fabioluxx Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@fabioluxx Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@fabioluxx Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@fabioluxx Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@fabioluxx Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@fabioluxx Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@fabioluxx Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@fabioluxx Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@fabioluxx Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@fabioluxx Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@fabioluxx Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@fabioluxx Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

thecyberd3m0n commented 5 years ago

Can I work on it? Is it opened?

StatusSceptre commented 4 years ago

@iurimatias Is a bounty for this issue still relevant? Cleaning up bounties on Gitcoin

embarklabs / embark-angular-template