search

embassy-collective / athan

A desktop Athan reminder designed and coded live on Twitch.
MIT License
22 stars 9 forks source link

Improve User Experience for Theme Selection #22

Closed Blackarrow299 closed 1 year ago

Blackarrow299 commented 1 year ago

Issue Summary: In the current version of the app, when users want to change the theme using the radio buttons (dark, light), they are required to save the changes before seeing the preview

Expected Behavior: After selecting a different theme option, the app should immediately provide a live preview of the chosen theme without requiring users to save the change first.

Stormix commented 1 year ago

It's currently not feasible with the way we have the global store setup. i.e, when you set the theme, it's persisted immediately, if we want to achieve this behavior, we need a separate temporary state that also controls the theme, but that is not persisted.

So unless, someone else takes a look into this, I don't think it's worth the effort.

Thank you however for the idea and your contribution.