search

embassy-rs / chiptool

Apache License 2.0
37 stars 21 forks source link

add err msg about renaming collision #24

Closed eZioPan closed 4 months ago

eZioPan commented 4 months ago

update:

this error message should be propagate to upper level to print more useful infomation - Done.

eZioPan commented 4 months ago

now it will print something like this:

thread 'main' panicked at src/transform/mod.rs:104:60:
called `Result::unwrap()` on an `Err` value: 
Err: on rename Fieldset "BSLOTR", new name "SLOTR" already exist
Err: on rename Fieldset "BCLRFR", new name "CLRFR" already exist
Err: on rename Fieldset "BSR", new name "SR" already exist
Err: on rename Fieldset "ACR1", new name "CR1" already exist
Err: on rename Fieldset "ADR", new name "DR" already exist
Err: on rename Fieldset "AFRCR", new name "FRCR" already exist
Err: on rename Fieldset "AIM", new name "IM" already exist
Err: on rename Fieldset "ACR2", new name "CR2" already exist
Dirbaio commented 4 months ago

ooh very nice, printing all the errors instead of the first is much better. thanks!