embassy-rs / embassy

Modern embedded framework, using Rust and async.
https://embassy.dev
Apache License 2.0
5.15k stars 713 forks source link

net: panic if too many DNS servers. #1816

Open Dirbaio opened 1 year ago

Dirbaio commented 1 year ago

we should truncate instead of panic.

temp workarond: add this feature to smoltcp.

smoltcp = { version = "0.10.0", default-features = false, features = [ "dns-max-server-count-4" ] }
Frostie314159 commented 1 year ago

I mean it explicitly mentions, that this panics under the condition, which you described. However, introducing a check and returning a Result might be more ideal, than just panicking.

MaikuMori commented 1 month ago

Agree about handling this gracefully