embassy-rs / embassy

Modern embedded framework, using Rust and async.
https://embassy.dev
Apache License 2.0
4.89k stars 665 forks source link

Add esp32 examples #2788

Open Firstyear opened 3 months ago

Firstyear commented 3 months ago

Hi there,

The project readme claims:

However, there are no examples of using esp-rs in this repository, and esp-rs make no mention of anything related to embassy or any examples in their ecosystem. The best I can find is a single example hidden in the esp wifi project. https://github.com/esp-rs/esp-wifi/blob/b18ed4a4f18dddc8ffe6f9c7e426a270c010024a/esp-wifi/examples/embassy_ble.rs#L17

Would it be possible add esp-rs examples?

lulf commented 3 months ago

There are plenty of examples with embassy for esp-rs in the esp-hal repo https://github.com/esp-rs/esp-hal/tree/main/examples/src/bin (anything prefixed with embassy).

Adding examples to embassy means additional hardware that must be tested, verified, documented and ... maintained, and since esp-rs best knows ESP and is able to keep it up2date I think that's a better place for it.