embassy-rs / embassy

Modern embedded framework, using Rust and async.
https://embassy.dev
Apache License 2.0
5.32k stars 734 forks source link

stm32/i2c: slave mode support #622

Open Dirbaio opened 2 years ago

jrmoulton commented 8 months ago

I'm interested in implementing stm32 i2c slave mode. I see there was a PR opened a while ago in #2118 but that there were some changes that needed to be made and the PR was marked as a draft. Would it be better to use that PR as a starting point or start from scratch and use the rp implementation as a reference?

bsodmike commented 6 months ago

Any update on this? Cc @Dirbaio

jrmoulton commented 6 months ago

I've started implementing it but haven't finished. Will probably get back around to it in a few weeks

jrmoulton commented 4 months ago

@bsodmike I have a draft PR open in #2909

Not quite finished but will likely be finished soon

barafael commented 4 months ago

@Dirbaio looks like this is implemented meanwhile and can be closed

bsodmike commented 4 months ago

Agreed, this issue can be closed as the PR should be merged soon post CI failures