feat(portal): made portal usable from interrupts

embassy-rs / nrf-softdevice

Apache License 2.0

256 stars 76 forks source link

feat(portal): made portal usable from interrupts #174

Closed Yandrik closed 1 year ago

Yandrik commented 1 year ago

This allows using the Portal from interrupts by locking all important resources with a CriticalSectionRawMutex if that is desired. Switches to a ThreadModeRawMutex automatically when the feature usable-from-interrupts is not enabled. When using the portal (or the softdevice overall) from interrupts without enabling it explicitly, a helpful message that reminds the user to activate the feature if they so desire is displayed.

Yandrik commented 1 year ago

Possible caveats:

Re-entrant calling is still somewhat possible, at least in theory. It gets detected and panics, but still, it's not impossible
The usable-from-interrupts feature enables the critical-section-impl feature. This might not be desired behavior in every case

Yandrik commented 1 year ago

maybe some more cases need to be added to the ci scripts to cover this properly, tho it might not really be necessary

Yandrik commented 1 year ago

Portal upgrade should be completely done now