Fix probe-rs "--binary-format" -> "--format" argument in README.md

embassy-rs / nrf-softdevice

Apache License 2.0

269 stars 80 forks source link

Fix probe-rs "--binary-format" -> "--format" argument in README.md #274

Closed JuliDi closed 3 months ago

JuliDi commented 3 months ago

In the latest version of probe-rs (23.0) the argument is now called "format". The Readme seems to be based on an older version of probe.

Helptext:

      --format <FORMAT>
          If a format is provided, use it. If a target has a preferred format, we use that. Finally, if neither of the above cases are true, we default to ELF

8cichy8 commented 3 months ago

This is wrong. You did reversed it to old format. This was changed in probe-rs this year. And actual version is 0.24.0 ...

JuliDi commented 3 months ago

Good catch, I must have missed that update (or messed up my PATH 😱)

@Dirbaio can you reverse the commit or should I make a new PR. I'm sorry for the mess!

Dirbaio commented 3 months ago

reverted in 991d28e