search

embassy-rs / stm32-data

75 stars 111 forks source link

Dac in stm32g431c8 #298

Closed jrmoulton closed 10 months ago

jrmoulton commented 1 year ago

The dac definitions are missing from this chip. It seems like it already has an entry in the perimap though.

It also has the data for it in the json. https://github.com/embassy-rs/stm32-data-generated/blob/4f60a9c3c9583915a33c842a35574bead53aa8da/data/chips/STM32G431C8.json#L670

What would I need to change?

Dirbaio commented 1 year ago

maybe it's not matching because it's named "DAC1", not "DAC". Otherwise, the actual version in the cubedb xmls is different to the ones listed in perimap.

jrmoulton commented 1 year ago

So it it just that the feature isn't being activated?

Dirbaio commented 1 year ago

the issue is the JSON doesn't have registers field. See here no registers, vs another chip that does have it.

There's no registers because no entry in perimap is matching. You'd have to debug why, and fix it.

jrmoulton commented 1 year ago

Ah I see. Thanks