search

embassy-rs / stm32-data

69 stars 101 forks source link

STM32G4 should have two copies of ADC_COMMON #438

Closed dlaw closed 4 months ago

dlaw commented 5 months ago

All instances of STM32G4 should have ADC12_COMMON at address 0x50000300 in addition to ADC345_COMMON at address 0x50000700. Currently stm32-metapac provides ADC_COMMON for ADC1/2 and does not map any of the common registers for ADC3/4/5.

2024-03-15-170218_632x579_scrot

2024-03-15-170231_644x218_scrot

dlaw commented 5 months ago

It's not clear to me how to fix this the right way. I can add ADC345_COMMON to data/extra/family/STM32G4.yaml, no difficulty there, but now I can't figure out how to rename the existing ADC_COMMON to ADC12_COMMON.