embassy-rs / stm32-data

66 stars 94 forks source link

Fix Memory Size for STM32G4...6/8 and STM32G4[34]..B #478

Closed AdinAck closed 2 months ago

AdinAck commented 2 months ago

The memory size for these chips was set to 20 KiB instead of 32. Perhaps a hex to dec conversion error.

Evidence that the correct size is 32 KiB: STM32G4xxxx STM32G441RB

Thanks!

embassy-ci[bot] commented 2 months ago

diff: https://ci.embassy.dev/jobs/acdf4e0dbafc/artifacts/diff.html

AdinAck commented 2 months ago

After looking closer at the datasheet I actually don't know how to modify the invocation of mem! to accurately represent the SRAM banks in these chips, but 20 KiB is still certainly wrong so I will change this to an issue.

embassy-ci[bot] commented 2 months ago

diff: https://ci.embassy.dev/jobs/073da65a88c9/artifacts/diff.html

AdinAck commented 2 months ago

woops: #301

Dirbaio commented 2 months ago

thanks!