search

embassy-rs / stm32-data

66 stars 94 forks source link

Kkoppul2/u5 comp support #494

Closed kkoppul2 closed 2 weeks ago

kkoppul2 commented 1 month ago

Add U5 comparator support Clean up U0 comparator yaml

embassy-ci[bot] commented 1 month ago

diff: https://ci.embassy.dev/jobs/fbde906e8a62/artifacts/diff.html

Dirbaio commented 1 month ago

why remove the winout, winmode, polarity enums? they're 1-bit, but they're not "useless" because they convery meaning. For example "polarity: NotInverted, Inverted" makes sense, "polarity: true/false" doesn't. it'd make sense if the field was named "invert: true/false" but it isn't.

kkoppul2 commented 1 month ago

That's fair, I'll update that.

embassy-ci[bot] commented 4 weeks ago

diff: https://ci.embassy.dev/jobs/db6401e476f9/artifacts/diff.html

kkoppul2 commented 4 weeks ago

@Dirbaio Fixed it