Post Production Migration Tasks

embassynetwork / modernomad

manage multi-use community houses: members, guests, events.

https://embassynetwork.com/

GNU Affero General Public License v3.0

132 stars 59 forks source link

Post Production Migration Tasks #483

Open jessykate opened 5 years ago

jessykate commented 5 years ago

[x] Purge hard coded media URLs in RoomDetail.jsx, location emails, and other @bfirsh #488
[x] distribute tarsnap keys
[ ] delete database dump from S3
[ ] 2FA all the things
- [ ] Heroku
- [ ] GitHub
- [ ] Cloudflare
- [ ] Mailgun
[x] charging card gives error "card was declined" but the charge actually goes through. (turns out this is a template error) #530
[x] add fake email sending to browser tests (would have caught above error) (unit test added in #530, which is probably good enough)
[ ] editing rate gives an error
[ ] click around more in manage pages
[ ] turn down alfred (eventually)
[ ] update email associated with stripe
[ ] update email associated with mailgun

jonathan-s commented 5 years ago

add fake email sending to browser tests (would have caught above error)

This is kind of tricky. It would mean that we would need to supply the api key for mailgun in clear text basically, which means it could be abused. I think the better answer is to write unit tests for the views..

bfirsh commented 5 years ago

@jonathan-s sorry these were not verbose enough. We mean just rendering the template for the email, even when emails are disabled. A bug in the email template broke approving bookings.

jonathan-s commented 5 years ago

@bfirsh Right :). Well, that should be solved by the anymail branch ;). It renders the email templates and outputs those into console. So if there was template error that branch should have caught that as far as I understand.

bfirsh commented 5 years ago

@jessykate Did we get anywhere with these things? Deleting the database dump and setting up 2FA are the important things, I think. :)