embedcard / jquery-datatables-row-grouping

Automatically exported from code.google.com/p/jquery-datatables-row-grouping
0 stars 0 forks source link

Group rows/cells get a generic identifying class, but group items only get a group-specific class, complicating identification #52

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Create a table with data
2. Initialize datatables
3. Inspect classes on group and its children

What is the expected output? What do you see instead?
The expected output is to see "group" class, group name as a class on the 
group, and expect to see "group-item" class and "group-item-groupName", where 
groupName is the group's name.

What I see is "group" and the groups name as classes on the group, but on the 
children there is only "group-item-groupName" and no generic "group-item" to 
easily select all children.

What version of the product are you using? On what operating system?
MacOSX 10.7.5
Chrome
DataTables 1.9.4
RowGrouping Plugin 1.2.7

Please provide any additional information below.
This is mainly to aid in styling. I don't want to unnecessarily use attribute 
selectors if I don't have to, so I looked into it and created a patch. This 
patch follows the same convention that "group" class does, as in it is 
configurable. I hope it helps.

Original issue reported on code.google.com by hegp...@gmail.com on 23 Jan 2013 at 6:32

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks for the patch.

Try the latest version of plugin - it adds group-item and 
group-item-<<groupname>> classes on all rows.

Jovan

Original comment by joc...@gmail.com on 6 Jun 2013 at 3:51