embedded-graphics / examples

Embedded graphics examples
Apache License 2.0
26 stars 5 forks source link

Housekeeping for 0.7 #12

Closed jamwaffles closed 3 years ago

jamwaffles commented 3 years ago

Progress towards #8 and #5, closes #7, closes #6.

jamwaffles commented 3 years ago

Rectangle intersection moved to embedded-graphics/debug-tools#9.

jamwaffles commented 3 years ago

A bit of a kitchen sink PR, but I think I've covered most points in the other issues in this repo

rfuest commented 3 years ago

Closes #8, closes #7, closes #6, closes #5

8 still need some work after this PR is done.

And this PR is a good start towards #5, but could also use some work. Should we also add licensing information to the readme?

rfuest commented 3 years ago
jamwaffles commented 3 years ago

To address your points in order:

  1. Agreed, that example really doesn't make sense here does it. Moved in embedded-graphics/simulator#26
  2. I've deleted it, as we already have the line debug tool which does the same thing AFAICS.
  3. Set to >0 now, looks better indeed.
  4. :+1:

As for the licenses, I can use the same structure as the e-g repo. Let me do that quick...

jamwaffles commented 3 years ago

Licenses are added, MIT or Apache 2.0 the same as e-g. I also added them to the Cargo.toml of each folder which isn't really necessary, but can't hurt.

rfuest commented 3 years ago

Some final comments:

jamwaffles commented 3 years ago

Changes addressed :)

rfuest commented 3 years ago

Should we "fork" the eg-0.7 examples directory in this PR? Because the Cargo.toml in eg-next was supposed to always use git dependencies.

jamwaffles commented 3 years ago

Ah, no, I think we should do that when 0.7 is released. Technically there's no proper release yet, so keeping eg-next as is for the short term makes sense to me. I've reverted the dependency changes back to the git/patches for this PR.

rfuest commented 3 years ago

OK. But I have to admit that finally seeing the Cargo.toml without any git dependencies looked really good.

jamwaffles commented 3 years ago

Thanks for the reviews! These examples look really good now.

But I have to admit that finally seeing the Cargo.toml without any git dependencies looked really good.

It did look spectacular! The quicker we can get the migration guide done the quicker we can release non-beta and go back to non-Git Cargo.toml utopia ;)