Closed jamwaffles closed 3 years ago
Rectangle intersection moved to embedded-graphics/debug-tools#9.
A bit of a kitchen sink PR, but I think I've covered most points in the other issues in this repo
Closes #8, closes #7, closes #6, closes #5
And this PR is a good start towards #5, but could also use some work. Should we also add licensing information to the readme?
simulator-input-handling
to the examples directory in the simulator
repo?line-thickness
to primitives-line-thickness
or also move it debug-tools
?demo-progress
to something != 0? This would make the screenshot more interesting.text-custom-font
will need to be fixed after the next beta release.To address your points in order:
line
debug tool which does the same thing AFAICS.As for the licenses, I can use the same structure as the e-g repo. Let me do that quick...
Licenses are added, MIT or Apache 2.0 the same as e-g. I also added them to the Cargo.toml
of each folder which isn't really necessary, but can't hurt.
Some final comments:
eg-seven-segment
based digital clock example to this repo: https://github.com/embedded-graphics/eg-seven-segment/blob/master/examples/digital-clock.rsprimitives-ellipse
and primitives-rounded-rectangles
are debug tools. Should we remove them? Both primitives are used in other examples.text-fonts
says: "Demonstrate the available builtin fonts." We should either change the comment to state that this is a subset of available fonts and a full list is included in the docs or add all fonts to the example. I guess the first solution would be easier to implement and maintain in the future.text-extended-characters
: The comment needs to be updated, because all builtin fonts support the characters in this exampleChanges addressed :)
Should we "fork" the eg-0.7 examples directory in this PR? Because the Cargo.toml
in eg-next
was supposed to always use git dependencies.
Ah, no, I think we should do that when 0.7 is released. Technically there's no proper release yet, so keeping eg-next
as is for the short term makes sense to me. I've reverted the dependency changes back to the git/patches for this PR.
OK. But I have to admit that finally seeing the Cargo.toml
without any git dependencies looked really good.
Thanks for the reviews! These examples look really good now.
But I have to admit that finally seeing the Cargo.toml without any git dependencies looked really good.
It did look spectacular! The quicker we can get the migration guide done the quicker we can release non-beta and go back to non-Git Cargo.toml
utopia ;)
Progress towards #8 and #5, closes #7, closes #6.