search

embedded-graphics / examples

Embedded graphics examples
Apache License 2.0
29 stars 6 forks source link

Add embedded-text example #13

Closed bugadani closed 3 years ago

bugadani commented 3 years ago

This is just the simplest possible example I could think of, that would otherwise be annoying to do in embedded-graphics. Surprisingly, things seem to work :)

Progress towards #8

jamwaffles commented 3 years ago

I added the check-readmes command but didn't add it into the CI config :facepalm:.

I also just noticed CircleCI didn't have the "Build forked pull requests" option turned on, which I've now enabled.

rfuest commented 3 years ago

I also just noticed CircleCI didn't have the "Build forked pull requests" option turned on, which I've now enabled.

Great, I was wondering why CI didn't work.

bugadani commented 3 years ago

Aww yessssss, e-t is MSRV 1.43.

rfuest commented 3 years ago

A forgot that e-t has a newer MSRV than e-g. Should we just disable the 1.40.0 build? I honestly don't care about 1.40.0 compatibility anymore and would like to change the MSRV policy as soon as 0.7 is released.

jamwaffles commented 3 years ago

I'd be happy to bump the MSRV too as I'm also not that bothered by it. Would we be ok just bumping to 1.43 for now and opening an issue in e-g to discuss what the new version/policy should be?

bugadani commented 3 years ago

I think examples are fine on stable only. MSRV is that - minimum supported, the crates can stay as low as they can/want IMO.

rfuest commented 3 years ago

We will also need to consider eg-bdf and eg-seven-segments MSRVs. I think they are 1.44.0, but I haven't checked in a while and without the proc macro they might work on older versions now.

I agree with @bugadani in that we should just require the latest stable version for the examples to keep this simple.

jamwaffles commented 3 years ago

Sounds good to me! Shall I attach that change to #14 ?

rfuest commented 3 years ago

Sounds good to me! Shall I attach that change to #14 ?

Yes, why not. Do you want to merge this PR in a semi broken state for now?

bugadani commented 3 years ago

Do you want to merge this PR in a semi broken state for now?

There's no rush on this one

jamwaffles commented 3 years ago

I just merged #14 so this PR should pass its build once rebased.

jamwaffles commented 3 years ago

Sweet!