search

embedded-graphics / examples

Embedded graphics examples
Apache License 2.0
29 stars 6 forks source link

Setup CI for this repo #4

Open rfuest opened 3 years ago

rfuest commented 3 years ago

CI should at least check that the examples build with the latest e-g versions. It would also be nice to check the actual output of the examples like e-t does: https://github.com/embedded-graphics/embedded-text/blob/master/.github/workflows/rust.yml

jamwaffles commented 3 years ago

I'm going to close this as done, as we've been building against a few versions now.

Comparisons are tricky, as the analog clock example generates a different image every time it's run due to displaying the current system time. I think it's ok to manually check the screenshots are up to date from time to time.

rfuest commented 3 years ago

I'm going to close this as done, as we've been building against a few versions now.

But this issue was specifically for testing the eg-next branch.

Comparisons are tricky, as the analog clock example generates a different image every time it's run due to displaying the current system time. I think it's ok to manually check the screenshots are up to date from time to time.

Sure, for the clock examples this is difficult, but all other examples should produce the same output every time.

We don't need to set this up right now, but I still think this is a good idea for the future.

rfuest commented 3 years ago

@jamwaffles Would you mind if we reopen this issue for later?

jamwaffles commented 3 years ago

Sure, sorry for being overzealous with my closures!