embeddedTS / meta-ts

2 stars 8 forks source link

machine file uses "IMAGE_INSTALL +=" #5

Closed d-k-c closed 4 years ago

d-k-c commented 6 years ago

I've tried to build an image based on the Morty branch of this Yocto layer, to run on a TS-7990. The corresponding machine file is "tsimx6.conf", but this file uses IMAGE_INSTALL += and that causes some packages not to be installed in our image.

Machine config file should use MACHINE_ESSENTIAL_EXTRA_RDEPENDS, MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS, MACHINE_EXTRA_RDEPENDS, and MACHINE_EXTRA_RRECOMMENDS to install packages they need.

Also, it's discouraged to tweak IMAGE_INSTALL with the += operator, because depending on the order in which files are parsed, it will modify this variable in unexpected ways. For instance in our case, it prevented the packages listed in core-image.bbclass from being installed, so our image was lacking VPU firmware, some kernel modules, and so on.

ts-kris commented 4 years ago

Confirmed building after applying the changes. @d-k-c do the changes made seem sufficient to you? Note that this is only in Zeus moving forward.

d-k-c commented 4 years ago

Sorry I completely missed this notification. Yes that seems sufficient but I haven't tested it

ts-kris commented 4 years ago

@d-k-c Thanks for the feedback. Will close this with #6, if you have any other issues related to this moving forward, feel free to reopen this issue in the future.