search

embeddedartistry / arduino-printf

Add printf support to the Arduino SDK
MIT License
91 stars 15 forks source link

Can't clone use without logged into github #15

Closed hmic closed 4 years ago

hmic commented 4 years ago

You specify the submodules with git@github.com URLs, which makes it necessary to be logged into github to clone them.

If you specify them as https://github.com/... they can just be used as is.

phillipjohnston commented 4 years ago

It's a habit from years of using private repositories, which require you to have SSH keys configured. I'm happy to make the fix, although I see here that you have a commit which addresses the issue. Did you want to submit it as a PR? I will gladly accept it.

phillipjohnston commented 4 years ago

Just found out I can open a PR using your fork - I'll get this merged today.

phillipjohnston commented 4 years ago

Closed by PR #16