Add support for overriding default Ethernet CS pin number using the EEPROM

embeddedartistry / athena-bootloader

An AVR Arduino bootloader that supports uploads over Ethernet (via TFTP) and Serial.

GNU Lesser General Public License v2.1

12 stars 5 forks source link

Closed phillipjohnston closed 3 years ago

hagaigold commented 2 years ago

Meg1284P with Sheild -a very rare setup I think.

I can use the pin mapping we have here -pins_arduino.h for a variant named 'bobuino'

or I can disable external pin setup for the Meg1284P :

#if !defined(__AVR_ATmega1284P__)
    initialize_eth_cs();
#endif

#if !defined(__AVR_ATmega1284P__)
    checkAndPerformEthernetReset();
#endif

any thoughts?

phillipjohnston commented 2 years ago

Hm, on these two, I think the Bobuino approach would be preferred, keeping behavior consistent. Do you see any downside to that?