Fix misuses read and write pointers

hagaigold commented 2 years ago

Description

Fix misuse of read pointer REG_S3_RX_RD0 & write pointer REG_S3_TX_WR0 for WIZnet shields: W5100 & W5200. As a result of this fix, tftpPoll function, which processing each new packet, was simplified, and the too-long delay, TFTP_PACKET_DELAY, in each iteration of tftpPoll function was reduced to 5ms (was 400ms).

Fixes #19 Fixes #18

other changes:

max address, MAX_ADDR, of code area fixed to match the makefile
global (extern) variables definition

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

see issue #19

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] My changes generate no new warnings

hagaigold commented 2 years ago

Great work!

thx :)

regarding the TFTP_PACKET_DELAY- I did tests with a 0 delay but left a 5 for "just in case" (don't have all the different boards & WIZs)

phillipjohnston commented 2 years ago

That's great to know, I filed #91 so we can at least give the option to remove it completely

embeddedartistry / athena-bootloader