embeddedt / ArchaicFix

Swiss army knife of bugfixes and performance improvements for MC 1.7.10
Other
68 stars 12 forks source link

Various GT6 mixins cause errors when other GT is found (for example the custom GT5u in GTNH) #116

Closed chochem closed 5 months ago

chochem commented 9 months ago

Various GT6 mixins cause errors when other GT is found instead (for example in the custom gt5u in GTNH) archaicfixerrors.txt (using archaicfix-0.7.1 in GTNH-nightly353)

I assume there is only a check for 'gregtech' being present which is rather unspecific. If detection of gt6 specifically is not easy to do, a config to turn off gt6 mixins (one-by-one or all) would also work as a solution.

SilearFlare commented 9 months ago

Shoe's on the other foot innit now you see the world through our :eyes:

GT6 detection is actually very simple, it's only a matter of specifying Loader.isLoaded('gregtech') && !Loader.isLoaded("gregapi")

makamys commented 9 months ago

The code you're describing detects GT5u, not GT6.

For clarity's sake, here are the modids declared by each major GT version:

Therefore for detecting GregTech 6 exclusively, a check for gregapi or gregapi_post would be appropriate.

(In fact, ArchaicFix already checks for gregapi in one place.)

SilearFlare commented 8 months ago

Well, good thing I never wrote that commit for gt6 checks on magic bees then, 'cause that's what I was gonna implement :smile: :+1:

embeddedt commented 5 months ago

Should be fixed