embeddedt / ArchaicFix

Swiss army knife of bugfixes and performance improvements for MC 1.7.10
Other
66 stars 9 forks source link

Added RPLE compatibility #121

Closed FalsePattern closed 2 months ago

FalsePattern commented 2 months ago

The priority 300 BlockMixin conflicts with RPLE's BlockMixin getLightValue redirect https://github.com/GTMEGA/RPLE/blob/57ae27dcb9891f968e10f7b52fbd4d5b1382d093/src/main/java/com/falsepattern/rple/internal/mixin/mixins/common/BlockMixin.java#L60, this PR moves the conflicting redirect to priority 2000 so that the mixin engine is happy.

The Overwrite is necessary on RPLE's side, as an Inject with a cancel causes extreme object allocation spam, and an ASM transformer is too dirty.

Also fixed a bug in the buildscript that caused mrjtpcore to stall the build for 5 minutes due to a weird jitpack interaction.

Fixing the compat on ArchaicFix's side makes more sense, as AF is a generic hotfix/patch/performance mod while RPLE is a content mod.