search

embeddedt / ArchaicFix

Swiss army knife of bugfixes and performance improvements for MC 1.7.10
Other
68 stars 12 forks source link

skipRenderingIfNotVisible Is laggy in my modpack, caused by entities? #89

Closed quentin452 closed 11 months ago

quentin452 commented 1 year ago

https://spark.lucko.me/k4qYhmLAdb Capture d’écran_2023-05-05_22-16-27

I get a significantly improvement when disabling this method in dev

edit :

~480 fps with skipRenderingIfNotVisible enabled with some special mobs through walls ~600 fps without skipRenderingIfNotVisible enabled with some special mobs through walls

but it seem that disabling skipRenderingIfNotVisible make some issues

couleurm commented 1 year ago

hey, lurking around: what kinda "setting" even is skipRenderingIfNotVisible and how can it be modified?

And what's spark.lucko.me, client side benchmarking?!! 🤨

quentin452 commented 1 year ago

hey, lurking around: what kinda "setting" even is skipRenderingIfNotVisible and how can it be modified?

And what's spark.lucko.me, client side benchmarking?!! raised_eyebrow

need to change the source code to remove skipRenderingIfNotVisible And i used /sparkc profiler run to profile client thread

embeddedt commented 11 months ago

Threaded chunk updating & the occlusion tweak were removed from ArchaicFix in 0.7.0, so this issue is no longer relevant.