search

embeddedt / CreateChunkloading

Fork of https://github.com/LordGrimmauld/createintegration with just the chunk loader
Other
6 stars 6 forks source link

1.18 chunkloading issue #5

Closed MuradAkh closed 2 years ago

MuradAkh commented 2 years ago

Hey I saw on curseforge that you had an issue with chunkloading in 1.18.

I also ran into an issue when portion little logistics to 1.18. It was resolved by setting the ticking parameter to false when you call forge chunk manager. My entities still tick from what I've tried. You might want to double check if other stuff ticks.

For reference https://github.com/MuradAkh/LittleLogistics/pull/96/files

embeddedt commented 2 years ago

Thank you so much for this information! That's a very counterintuitive fix, but if it works, I'll be more than happy to give you credit.

By the way, I've seen your mod before - very cool concept.

On Fri., Feb. 25, 2022, 1:05 a.m. Murad Akhundov, @.***> wrote:

Hey I saw on curseforge that you had an issue with chunkloading in 1.18.

I also ran into an issue when portion little logistics to 1.18. It was resolved by setting the ticking parameter to false when you call forge chunk manager. My entities still tick from what I've tried.

For reference https://github.com/MuradAkh/LittleLogistics/pull/96/files

— Reply to this email directly, view it on GitHub https://github.com/embeddedt/CreateChunkloading/issues/5, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKHTVAG22WQ7ICL74L22TCLU44L2BANCNFSM5PJLZL6A . You are receiving this because you are subscribed to this thread.Message ID: @.***>

embeddedt commented 2 years ago

It worked perfectly! Thanks again for your help.

MuradAkh commented 2 years ago

Yeah I'm not entirely sure if this is a forge bug or ticking is meant for something else. I will probably look more deeply into it when I have time. Did you verify that tile entities still tick?

embeddedt commented 2 years ago

I suspect it's a Forge bug, because this worked correctly in 1.16 (at least for me), and the API contract didn't change. I didn't check on tile entities because Create contraptions are real entities. I would assume that real entities and tile entities behave the same way, but I could be wrong.

embeddedt commented 2 years ago

Looks like https://github.com/MinecraftForge/MinecraftForge/pull/8775 will solve this for 1.19 and a backport for 1.18 is also open.