search

embeddedt / ModernFix

Minecraft 1.16 & 1.18+ bugfix/performance mod
https://www.curseforge.com/minecraft/mc-mods/modernfix
Other
164 stars 12 forks source link

ModernFix causing frequent server crashes #446

Open mkern1200 opened 1 month ago

mkern1200 commented 1 month ago

Bug Description

Our server has been experiencing repeated crashes over the last week, which (after extensive testing) seem to be resolved only by removing ModernFix from our modpack. Possibly an incompatibility with another mod, but I'm having a lot of difficulty reproducing the issue, so I can't give too much information for this. There are a few different errors given in the crash reports/logs when this happens, but they all seem very similar, which leads me to believe the attached crash reports were all triggered by the same issue. We've done numerous tests on the one repeatable instance we were able to isolate (despite not knowing what was causing the crashes even in that instance) using versions 5.19.0, 5.18.10, 5.18.6, and 5.18.0 of your mod for Fabric 1.20.1, but every tested version seems to cause this same error. Only by removing ModernFix were we able to perform our test case without a server crash.

Reproduction Steps

I genuinely have no clue. Our test case was one of our players placing a row of soul sand in a certain area of his base in the world. We caught the crashes happening while he was doing this, and saved a backup of the world to perform troubleshooting on. Once we isolated and removed ModernFix, the crashes no longer occurred, and we removed the mod from our main server. This issue hasn't occurred in the 12 hours since that time, so I'm fairly confident that fixed it. But again, I could never find what exactly was triggering this to happen, only that it occurred in one specific case and did not occur when the mod was removed.

Log File

Here are the crash reports for our server from the last week that seem to be related to this issue, as best I am able to determine. The folder contains 32 of these crash reports. I'm happy to provide any additional details I possibly can.

Crash Reports.zip

embeddedt commented 1 month ago

Have you tried to reproduce this without C2ME? This looks like another mod changing entity chunk statuses on the wrong thread (which would lead to random exceptions from fastutil). I am not sure that ModernFix is actually causing the issue; it might just speed up some server process enough to make the crash happen more consistently. I also tried debugging locally with just ModernFix, and could not recreate a situation in which the crash would be possible.

mkern1200 commented 1 month ago

C2ME was one of the first mods I tried removing, and the issue still occurred without it. I do recognize the possibility that this is actually caused by something else, ModernFix was just the only catalyst for this type of crash that I could find by trail-and-error.

embeddedt commented 3 weeks ago

What happens if mixin.bugfix.paper_chunk_patches is disabled in the ModernFix config?