search

embeddedt / ModernFix

Minecraft 1.16 & 1.18+ bugfix/performance mod
https://www.curseforge.com/minecraft/mc-mods/modernfix
Other
164 stars 12 forks source link

Incompatibility with Distant Horizons #448

Open thvless opened 1 month ago

thvless commented 1 month ago

Bug Description

Running 1.20.1, Forge 47.2.18, Modernfix 5.18.1, Distant horizons 2.1.2.a

For context i have pregenerated the world with chunky then started pregenerating distant lod data using DH's distant generation, it had been doing well for a few hours, even reached the worldborder in some points (i set it to 5000 and pregenerated everything inside the border)

Then seemingly randomly the game crashed with Cannot invoke "it.unimi.dsi.fastutil.longs.LongArrayList.getLong(int)" because "this.wrapped" is null, for context this is all in singleplayer

after this everytime id load into the world (DH still working) it would crash after a few moments, if i had to guess it would be DH spawning pregen threads (it's very aggressive when set to the highest setting) and messing with fastutil, seems related to #446

what puzzles me is that it had been generating thousands of chunks of LOD data and the logs dont seem to point out a specific issue

Removing modernfix fixes the crash

Reproduction Steps

Create New world, disable DH rendering and distant generation Set Worldborder to 5000 Pregenerate 2500 block radius with chunky Enable distant horizons and enable distant generation, medium quality, i paid for the whole cpu preset wait and Trust me bro™

Log File

crash-2024-08-02_20.25.12-server.txt latest.log modlist.txt debug(1).log

Jszp03 commented 1 month ago

big if true

WretchedAbyss commented 1 month ago

Same issue in 1.21, have had no issue after removing the mod. Seems to be true

embeddedt commented 3 weeks ago

There are very few optimizations in ModernFix that touch chunk generation scheduling, I suspect this is a DH issue. However, you can try disabling mixin.bugfix.paper_chunk_patches in the ModernFix config and see if it makes a difference.