search

embeddedt / ModernFix

Minecraft 1.16 & 1.18+ bugfix/performance mod
https://www.curseforge.com/minecraft/mc-mods/modernfix
Other
165 stars 12 forks source link

Exception baking Tiny Potato from Botania with Dynamic Resources enabled #459

Closed anoomolu closed 3 weeks ago

anoomolu commented 3 weeks ago

Bug Description

Hiya. It's not a visual issue but the Tiny Potato from Botania seems to raise a warning/error in the log, this is on a small test instance but happens with just Modernfix and Botania too. The warning in the log says the below:

[Render thread/WARN]: Unable to load model: 'botania:tiny_potato/' referenced from: botania:tiny_potato/: com.google.common.cache.CacheLoader$InvalidCacheLoadException: CacheLoader returned null for key botania:models/tiny_potato/.json. [Render thread/ERROR]: Exception baking botania:tiny_potato/: org.embeddedt.modernfix.dynamicresources.ModelMissingException

Reproduction Steps

Install Botania, Patchouli, Trinkets, Fabric API and Modernfix. All on Fabric 1.20.1, latest releases. Enable dynamic resources in the Modernfix config. Restart the game and load up a test world. Upon finding and placing a Tiny Potato, the warning/error pop up in the log.

Log File

https://mclo.gs/xf82l9j

embeddedt commented 3 weeks ago

This is expected behavior, the way Botania handles the tiny potato model is... weird. If I recall correctly, it relies on failing to load a model to show the default potato. I could theoretically suppress the error message but that would probably hide an issue in a future version if it ever breaks again (it has broken before).