embeddedt / TinkerLeveling

Rewrite of Tinkers Tool Leveling for 1.18
MIT License
1 stars 4 forks source link

Makes items unstackable. #2

Closed MrFieldBird closed 1 year ago

MrFieldBird commented 2 years ago

When i use this mod in my modpack crafted items don't stack with dropped ones, even all of their ID's and NBT tags are identical.

embeddedt commented 1 year ago

Does this occur with only this mod and Tinkers installed? I am having trouble reproducing it.

CyperCyang commented 1 year ago

Does this occur with only this mod and Tinkers installed? I am having trouble reproducing it.

Yes, the problem will occur with only tinkers' dependency , tinkers and tinker leveling were installed. The NBT shown in F3+H command is identical, but when I use the IBE Editor mod to check the items which cannot stack, it shows that the crafted items is ' {xxx.xxx{tag:{}}' and break item is '{xxx.xxx}' ,the difference make them unstackable. Mostly occurred on torch, ingot: the torch that be washed off or broken cannot stack with the crafted torch, but thrown and picked up crafted and not used torch can stack with the newly crafted torch. Unable to fix this problem by placing items into a box but using a hopper to transfer the items in a box can fix the problem, this act will add the 'tag:{}' to none 'tag' items and make them stackable. Besides, restart the game can change the NBT of the items player has and fix present problem, but the new items always have the problem.

embeddedt commented 1 year ago

Thanks, turned out to be a pretty obscure issue. It should be fixed in 0.3.0, but I don't think I can do anything about existing items that don't stack. The issue should not reoccur.

darchukoleksandr commented 1 year ago

It's also relevant to 1.16.5 Minecraft version. Please update it as there's no build for 0.3