search

embeddedt / VintageFix

FerriteCore and ModernFix venturing into the stone age of 1.12
https://legacy.curseforge.com/minecraft/mc-mods/vintagefix
Other
66 stars 6 forks source link

Freeze on exit singleplayer world #103

Open xJon opened 2 months ago

xJon commented 2 months ago

VintageFix has features to resolve reported issues of world freeze on world exits (mixin.bugfix.exit_freeze). I've experienced one now with VF installed, after opening a singleplayer world to LAN. Thread dump: https://mclo.gs/CojlvF3#L897

yum13241 commented 2 months ago

With VintageFix loaded and at default settings, I can't even enter a world. It's something related to an "alternate server main loop", what do I turn off to disable that alternate loop?

xJon commented 2 months ago

@yum13241 I'm not sure it is the same issue I am talking about.

xJon commented 2 months ago

Occurred again without opening to LAN (seems to always occur on full screen though?): https://mclo.gs/CojlvF3#L897

Edit: Occurred again, no LAN: https://mclo.gs/VM9BeYQ#L871

embeddedt commented 1 month ago

The log shows that Futures.getUnchecked is being used to wait for the server to stop, even though VF redirects that and should be using different logic. It seems likely that another mod is overwriting VF's fix, probably through ASM (as otherwise there would be a mixin error), which is not something I can easily solve on my end.

xJon commented 1 month ago

Oh well, was worth trying either way, and it doesn't occur too often.