search

embeddedt / VintageFix

FerriteCore and ModernFix venturing into the stone age of 1.12
https://legacy.curseforge.com/minecraft/mc-mods/vintagefix
Other
66 stars 6 forks source link

[Bug] Can't render GregTechCEu lamp blocks in inventory when Connected Textures Mod is present #112

Open MCTian-mi opened 1 month ago

MCTian-mi commented 1 month ago

When CTM, GregTechCEu, VintageFix are all present, some lamps doesn't render in inv:

{A2C0A8F5-6CA0-4011-8B48-2286A0D0851C}

With either CTM or VintagFix absent, lamp blocks renders normally in inv:

{FA85CE25-DD21-4fa4-86D8-5A05A54A23D2}
embeddedt commented 2 weeks ago

I noticed your PR, so I tried tweaking ViF to load AbstractCTMBakedModel less eagerly (to avoid aggressively reading BlockRenderLayer values) but that didn't help.

My suspicion is that this logic in GTCEu isn't effective with ViF because the CTM model wrapping will end up running in the middle of their logic instead of after, as a side effect of ViF having to reimplement the wrapping for dynamic loading.

MCTian-mi commented 2 weeks ago

I noticed your PR, so I tried tweaking ViF to load AbstractCTMBakedModel less eagerly (to avoid aggressively reading BlockRenderLayer values) but that didn't help.

My suspicion is that this logic in GTCEu isn't effective with ViF because the CTM model wrapping will end up running in the middle of their logic instead of after, as a side effect of ViF having to reimplement the wrapping for dynamic loading.

I checked that PR again and runs clean before launching, and it seems not to fix the issue here tbh it seems really weird I'll take your advice and see if I can fix this in that way.