embeddedt / VintageFix

FerriteCore and ModernFix venturing into the stone age of 1.12
https://legacy.curseforge.com/minecraft/mc-mods/vintagefix
Other
65 stars 5 forks source link

Problems with Resource Loader #14

Closed lLuffy-1PK closed 1 year ago

lLuffy-1PK commented 1 year ago

After adding items and blocks using Content Tweaker, they do not display textures that are loaded using Resource Loader image

embeddedt commented 1 year ago

What folder are the resources being put in? Is it oresources?

lLuffy-1PK commented 1 year ago

Most in the resources folder, some in oresources

embeddedt commented 1 year ago

Are they arranged like resources/<namespace>/textures/blocks or resources/<namespace>/textures/items, or is it a different subfolder besides blocks/items? The ContentTweaker items in E2EU seem to be working fine so I'm trying to figure out what is different about your setup.

lLuffy-1PK commented 1 year ago

In the screenshot I think you can see how it is located, without your mod they are loaded correctly.

image

embeddedt commented 1 year ago

Interesting, that folder path should work fine, can I have a look at the latest.log?

Abalieno commented 1 year ago

Having problems also with Supersymmetry:

ykikl

tukuyk

yiluily

But can't download the latest nightly for some reason. Download times out.

Quick look at log shows a bunch of spam: [Client thread/WARN] [VintageFix]: Property gregtech.common.blocks.properties.PropertyMaterial uses the same value null multiple times

But it's probably nothing.

There are other errors like this: [Client thread/ERROR] [org.embeddedt.vintagefix.dynamicresources.model.DynamicBakedModelProvider]: Error occured while loading model gregtech:metaitems/battery.mv.lead_acid/8#inventory

But all other custom items with a textures are also missing their texture and I don't see anything in the log.

All stuff within resources\gregtech\textures\items\metaitems

jchung01 commented 1 year ago

Also experienced this issue when trying out the mod in the modpack Meatballcraft, but I can reproduce it in the following minimal environment:

Using the following minimal scripts and resources copy-pasted from E2EU .minecraft/scripts/VanillaFactory.zs:

#priority 9000

#loader contenttweaker

mods.contenttweaker.VanillaFactory.createCreativeTab("other", <item:minecraft:coal:1>).register();

function buildItem(name as string) {
    val item = mods.contenttweaker.VanillaFactory.createItem(name);
    item.setCreativeTab(<creativetab:other>);
    item.register();
}

buildItem("bee_diversity");
buildItem("modularium");
buildItem("anglesite");
buildItem("benitoite");
buildItem("tankframe");
buildItem("twilighttrophy");

and resources in .minecraft\resources\contenttweaker\textures\items: ct_textures With VintageFix: 2023-06-04_22 27 38 Without VintageFix, the textures render correctly: 2023-06-04_22 37 55

latest.log debug.log (I believe ContentTweaker finds its own resources from the \resources folder, so this specific issue doesn't really have to do with the ResourceLoader mod, although I have not tested if resource loaded by ResourceLoader are missing textures as well)

Disabling mixin.dynamic_resources in the config restores the textures, if that helps narrows it down any.

embeddedt commented 1 year ago

Think I tracked down the cause of this; I realized that it could not handle Windows file paths correctly, but I use Linux so I didn't know. :laughing: This should hopefully be fixed now with the latest commit.

juraj-hrivnak commented 1 year ago

I can confirm that this issue is resolved with 6a66f329d069026421bdebd1a6c0a9b08834b806 on Windows.

embeddedt commented 1 year ago

Excellent, thanks.