embeddedt / VintageFix

FerriteCore and ModernFix venturing into the stone age of 1.12
https://legacy.curseforge.com/minecraft/mc-mods/vintagefix
Other
66 stars 6 forks source link

TXLoader first load lose ContentTweaker textures #33

Closed mczph closed 1 year ago

mczph commented 1 year ago

TX Loader

Modlist: image

ZenScripts:

#loader contenttweaker
import mods.contenttweaker.VanillaFactory;
import mods.contenttweaker.Item;

VanillaFactory.createItem("test").register();

First load: image

Second load: image

The texture is located at: image

embeddedt commented 1 year ago

Not sure exactly why this would happen only once. Does ContentTweaker generate the item model JSON by itself on the first load? That could be problematic.

mczph commented 1 year ago

Yes.

JuiceyBeans commented 1 year ago

Can reproduce in Technological Journey

On Sun, 25 Jun 2023, 10:52 mczph, @.***> wrote:

TX Loader https://www.curseforge.com/minecraft/mc-mods/tx-loader

Modlist: [image: image] https://user-images.githubusercontent.com/103164772/248535496-afae330d-3639-4bdf-a367-c934864bef7d.png

ZenScripts:

loader contenttweaker

import mods.contenttweaker.VanillaFactory; import mods.contenttweaker.Item;

VanillaFactory.createItem("test").register();

First load: [image: image] https://user-images.githubusercontent.com/103164772/248535624-ae06f6a7-5e8a-4e65-85d7-3d69f29f9b47.png

Second load: [image: image] https://user-images.githubusercontent.com/103164772/248535672-5b3cf42a-2fd7-4c87-8291-430f38c27ab0.png

The texture is located at: [image: image] https://user-images.githubusercontent.com/103164772/248535715-96d3e4e9-1953-4490-b723-63d9e978bcad.png

— Reply to this email directly, view it on GitHub https://github.com/embeddedt/VintageFix/issues/33, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASANZLV5XDUDLXWLMEZS2FDXM7N2JANCNFSM6AAAAAAZS62TDQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Abalieno commented 1 year ago

TJ loads in 55 seconds with Vintagefix 2.5, which is nice, but I can confirm it has some textures issues and they don't get solved on reloading.

There's a problem of steam piston and motors missing textures, that are added by contenttweaker, but there's also an issue with base machine casings that look blue-ish, rather than the usual gray...

I think these are just internal GT textures.

ukyukyky

Also, I don't think TJ has TX loader.

embeddedt commented 1 year ago

What's TJ?

JuiceyBeans commented 1 year ago

Technological Journey

On Sun, 2 Jul 2023, 21:46 embeddedt, @.***> wrote:

What's TJ?

— Reply to this email directly, view it on GitHub https://github.com/embeddedt/VintageFix/issues/33#issuecomment-1616747549, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASANZLWVSOSRKVOTUZJFZADXOGXV7ANCNFSM6AAAAAAZS62TDQ . You are receiving this because you commented.Message ID: @.***>

whatsapp2 commented 1 year ago

Also have problems playing audio from custom records that were made using content tweaker. Records show no texture as well.

embeddedt commented 1 year ago

Can someone verify if the resource loader issues are fixed in 0.2.6? The blue GT machines are a separate issue, I think.

embeddedt commented 1 year ago

I think the original Resource Loader issue is fixed.