When vintagefix is enabled i got higher tps overhead during worldgen - Githubissues

embeddedt / VintageFix

FerriteCore and ModernFix venturing into the stone age of 1.12

https://legacy.curseforge.com/minecraft/mc-mods/vintagefix

Other

66 stars 6 forks source link

When vintagefix is enabled i got higher tps overhead during worldgen #39

Closed quentin452 closed 1 year ago

quentin452 commented 1 year ago

When vintagefix is enabled i got higher tps overhead during worldgen

this issue can be fixed by disabling mixin.bugfix.missing_edge_chunks

mods lists :

!mixinbooter-7.1
Patcher-1.12.2-1.8.7a
vintagefix-0.2.7
!configanytime-1.0
UniversalTweaks-MB7-1.12.2-1.7.0

note :

I used Universaltweaks to use chunkgenlimiter to watch accurate tps usage with patcher mod

videos :

Vintagefix enabled

https://mega.nz/file/HpUEhJzB#TaN04-6Kmpyz2A3nVAEJ5vw8Z-mY8uKJlPnIifnPsyo

Vintagefix disabled

https://mega.nz/file/moFCzYTY#H5cznLNSoNgnZNXfPY7IhJwlBISWW7JiP8MyvDRHBMA

embeddedt commented 1 year ago

This is a mostly expected side effect of increasing the radius of generated chunks; I don't think it's really possible to fix without reintroducing the original bug. However as you've noted it can be disabled if the added overhead is really a concern. In practice modded worldgen is usually laggy enough that you would need to pregenerate anyway.