embeddedt / VintageFix

FerriteCore and ModernFix venturing into the stone age of 1.12
https://legacy.curseforge.com/minecraft/mc-mods/vintagefix
Other
66 stars 6 forks source link

Chisels and Bits ModIdMappingEvent causes lag #47

Closed embeddedt closed 1 year ago

embeddedt commented 1 year ago

https://github.com/ChiselsAndBits/Chisels-and-Bits/blob/1d7309e06dec869d12e97e648133b57f6e91f067/src/main/java/mod/chiselsandbits/chiseledblock/data/VoxelBlob.java#L123

Interaction with CTM's coremod causes this to yank in a model for each block state if both are present - not ideal. Will fix by rewriting it to compute the cache on the fly by ID - this will also fix JEID compat.