search

embeddedt / VintageFix

FerriteCore and ModernFix venturing into the stone age of 1.12
https://legacy.curseforge.com/minecraft/mc-mods/vintagefix
Other
66 stars 6 forks source link

Adapt CensoredASM's improvements to model condition canonicalization? #51

Closed jchung01 closed 1 year ago

jchung01 commented 1 year ago

CensoredASM provides model condition canonicalization based off of FerriteCore (which I am aware VintageFix is based on), which is default disabled in its config. Some "improvements" are mentioned in the implementation, mainly using what I assume are theoretically more efficient data structures for 1.12. Although I cannot vouch for any real performance improvements, I would like to suggest adapting the changes from CensoredASM into this mod's KeyValueConditionImpl. Feel free to close if I'm mistaken about these changes being compatible with how VintageFix changes model loading.

embeddedt commented 1 year ago

KeyValueConditionImpl is not used anymore. I removed that part of FerriteCore as it had compatibility issues with some 1.12 mods, and the deduplication fixes aren't nearly as important in the default VintageFix configuration as not many models are loaded at once anyway. It's probably safe to enable the CensoredASM implementation instead if one needed this change for some reason.