search

embeddedt / VintageFix

FerriteCore and ModernFix venturing into the stone age of 1.12
https://legacy.curseforge.com/minecraft/mc-mods/vintagefix
Other
66 stars 6 forks source link

Failed apply mixin to ObfuscationReflectionHelper with `MixinTargetAlreadyLoadedException` #88

Open SettingDust opened 6 months ago

SettingDust commented 6 months ago

I'm mixin into ObfuscationReflectionHelper in my mod. But VintageFix breaking that with MixinTargetAlreadyLoadedException

SettingDust commented 3 weeks ago

https://github.com/embeddedt/VintageFix/blob/22b5d1dd975300307f8558a0d42b9585182b7aea/src/main/java/org/embeddedt/vintagefix/core/VintageFixCore.java#L81-L87

The fields on the CL won't be obfed. It's launch wrapper instead of the game itself.

And also https://github.com/embeddedt/VintageFix/blob/main/src/main/java/org/embeddedt/vintagefix/transformercache/TransformerCache.java#L117

embeddedt commented 3 weeks ago

Does https://github.com/embeddedt/VintageFix/commit/803605ac8e182e8a6993e90d3b847f5ae0c6b7ba help?

SettingDust commented 3 weeks ago

It does