search

embeddedt / VintageFix

FerriteCore and ModernFix venturing into the stone age of 1.12
https://legacy.curseforge.com/minecraft/mc-mods/vintagefix
Other
66 stars 6 forks source link

Binnie's Extra Trees broken particles fix doesn't work with VintageFix #99

Closed xJon closed 4 months ago

xJon commented 4 months ago

https://github.com/ACGaming/UniversalTweaks/pull/447

Referring to: Lumbermill, Woodworker, Panelworker, Fruit Press, Brewery, Distillery, Glassworker Does not affect the Forestry broken particles fix though (e.g. Arborist's Chest).

embeddedt commented 4 months ago

https://github.com/ACGaming/UniversalTweaks/blob/01edaae6a4c41af41a8f2e19c834bc53a88f42c1/src/main/java/mod/acgaming/universaltweaks/mods/forestry/extratrees/UTExtraTreesParticlesFixer.java#L24-L30

For compatibility with dynamic resources, this loop needs to iterate over the blockstates for the machine block and get their model resource locations manually, rather than iterating the model registry and filtering for matching locations. It's very annoying/difficult to emulate the full set of model keys on my end.

embeddedt commented 4 months ago

If it's absolutely necessary to make it work from my end I can try, but I think my proposed fix should be easy enough.

xJon commented 4 months ago

@embeddedt I appreciate it, although it's already figured out, as a direct patch to Binnie's (https://github.com/ACGaming/Binnie/pull/5) ended up being a good & compatible solution.