search

embeddedt / aquaacrobatics

Fancy swimming, elegant sneaking: modern movement without compromises in 1.12.
https://www.curseforge.com/minecraft/mc-mods/aqua-acrobatics
The Unlicense
18 stars 10 forks source link

Compatibility with Immersive Intelligence #61

Open Carvercarver1 opened 2 years ago

Carvercarver1 commented 2 years ago

Hello. Can you do a compatability addition for thebetweenlands? They seem to have their own water fog, but fog from this mod and TBL seem to conflict. And thus, TBL's water fog is not present, it seems. Can you add a fog enabled seting per dimension? Or blacklists in case other mods change the fog in their dims.

And the second one: Can there be a compatibility with some Immersive Intelligence mod features please? Mainly, ignoring bullet entities for forcible bending/crouching/crawling, and compatibility with it's flippers. And, possibly, with it's scuba tank. In case of one, it happens with bullet entities from II which are made solid, but it causes AA to automatically crawl instead of ignoring them, and In case of the second: flippers are supposed to increase the movement speed in water, but it seems that AA modifies swimming mechanics and thus flippers don't add on to anything. And scuba tank is simple: unless II's scuba tank is still WIP, it doesn't acount for changes in the air system, where it should technically give more time underwater. I am yet to discuss the last two issues (flippers and scuba) with the mod author, Pabilo8, but first one could already be looked at. And thebetweenlands as well.

Thanks.

embeddedt commented 2 years ago

Thanks for the issue. Both suggestions sound good to me. Unfortunately I will only have time to look into the fog integration in the near future, as the other integration will require some more thought and implementation.

Carvercarver1 commented 2 years ago

That's alright! :)

Still, for the other integration you can make it somewhat of a list or a coursor, which would make instances of the specific mods to be ignored in entity collision. Or option to ignore entities? Something will need to be figured out in it's own time I guess. Thanks for reply.

embeddedt commented 2 years ago

Betweenlands compatibility has been added in 1.9.0.

Carvercarver1 commented 2 years ago

Scuba tank from II is fixed.

embeddedt commented 2 years ago

I looked into the bullet issue. EntityBullet appears to be marked as a collidable entity by the mod (at least, canBeCollidedWith and getCollisionBoundingBox are implemented), so I think the behavior on my end is expected?